refactor(cli): separate parser data and main function logic#1670
Closed
bearomorphism wants to merge 10 commits into
Closed
refactor(cli): separate parser data and main function logic#1670bearomorphism wants to merge 10 commits into
bearomorphism wants to merge 10 commits into
Conversation
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
docs(exception): add comment for updating exit code doc
bearomorphism
force-pushed
the
refactor-parser
branch
from
883cfd9 to
d35c29c
Compare
Member
|
I'm not sure I like splitting the cli into 2 files. I expect to find the args of a cli in the |
Member
|
I don't have a strong opinion on this one 🤔 either way works for me. so I'll let you both discuss whether we want to make change like this one |
Collaborator
Author
I don't expect a main function to be so large, but I also see your point. Maybe we group cli related thing into a file, and other things, such as excepthook and configuration file related things, into another file? |
Collaborator
Author
|
For example
|
Member
|
That'd be fine by me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main function is getting a bit large. I believe it is better to separate the core main function logic with cli configuration data for maintainability.
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and tests